feat(worker): remove stale import findings for successful record #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds functionality to the worker to clear any existing import findings for a record that previously failed to import, but now does. This avoids confusing historical findings existing for records that are successfully importing now. Part of google#2189 and google#2188
andrewpollock
requested review from
oliverchang,
hogo6002,
michaelkedar,
cuixq and
another-rex
hogo6002
reviewed
Dec 2, 2024
| finding = osv.ImportFinding.get_by_id(vulnerability.id()) | ||
| if finding: | ||
| logging.info('Removing stale import finding for %s', vulnerability.id()) | ||
| finding.key.delete() |
There was a problem hiding this comment.
Just a random thought, will we ever need to query historical finding data? For example, to evaluate how many records the linter helped fix?
There was a problem hiding this comment.
will we ever need to query historical finding data?
In my opinion, it's more of a "nice to have" than a strong "need" in terms of requirement. Yes, it's helpful to be able to quantify impact. We can determine that from the logs for as long as we have log retention for...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to the worker to clear any existing import findings for a record that previously failed to import, but now does. This avoids confusing historical findings existing for records that are successfully importing now.
Part of #2189 and #2188