Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): do not update source if it is unknown #2928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(worker): do not update source if it is unknown #2928

wants to merge 2 commits into from

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Nov 27, 2024 •
edited
Loading

Currently, get_source_repository returns None for unknown sources, which causes AttributeError.
To prevent this, this PR logs the source and then returns.

@cuixq cuixq changed the title fix(worker): do not update source if it is none fix(worker): do not update source if it is unknown Nov 27, 2024
@cuixq cuixq marked this pull request as ready for review November 27, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpollock andrewpollock Awaiting requested review from andrewpollock

@hogo6002 hogo6002 Awaiting requested review from hogo6002

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cuixq