chore: Remove deprecated setup.py and fix license #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpollock
approved these changes
Nov 27, 2024
|
Great work! 😁 |
oliverchang
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
nice! are we able to check if https://github.com/google/osv.dev/blob/master/.github/workflows/publish-to-pypi.yaml still works with this?
|
I manually ran the command (build) with setup.py deleted and it created the same files as when setup.py were present. (it was actually ignoring the presence of setup.py completely, and using pyproject.toml (poetry-core) by default) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove setup.py as it is unnecessary, as pyproject.toml is a superset of it.
Also fix the license, not sure why it was labelled MIT, when all our license files and headers are Apache-2.0.