fix(website): replace confusing utils.is_prod() function #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkedar
requested review from
oliverchang,
andrewpollock,
hogo6002,
cuixq and
another-rex
andrewpollock
approved these changes
Nov 26, 2024
| except DefaultCredentialsError: | ||
| project = '<unknown>' | ||
|
|
||
| # TODO(michaelkedar): Is there a way to avoid hard-coding this? |
There was a problem hiding this comment.
Might it be easier (and potentially safer) to hard-code the production project ID (which is somewhat inescapable, and also more durable) and fail open to the non-production hostname for everything else?
There was a problem hiding this comment.
Changed it to fall back to api.test.osv.dev.
another-rex
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.is_prod()was actually checking if we were running on Cloud Run (returning True if running on 'oss-vdb-test').Renamed it to
is_cloud_run()to be less confusing.Also created
utils.api_url()to use whereis_prodwas being used incorrectly.