fix(analysis): better tolerate GIT analysis crashes #2884
Merged
+338
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit discards any GIT events when known failures in analysis are seen, so that the rest of the record may still be imported successfully. When GIT range analysis crashes, the entire record is discarded. The record's `affected[]` may contain other non-GIT events (i.e. `package` entries) that will be of value. There are two known scenarios where GIT range analysis crashes: - the commit being analysed is an orphaned commit - the commit cannot be found in the repository (because it is from a fork) Includes a test to ensure that invalid GIT events are removed from records crashing analysis (and the record otherwise imports successfully)
|
@pxp928 FYI |
oliverchang
reviewed
Nov 20, 2024
|
Once this is in Production, it should allow for the successful (partial) import of: |
This commit acts on reviewer feedback and:
- treats individual instances of invalid commits as invalid
- Orphaned commits are treated the same as other classes of invalid
commits
- Commits not found in a branch are handled more gracefully
- Entire GIT ranges are no longer excluded as a result of this
This commit reverts an unnecessary change to reduce the size of the diff It also corrects the test docstring to match the newer reality
oliverchang
reviewed
Nov 21, 2024
oliverchang
reviewed
Nov 21, 2024
A different approach was taken
oliverchang
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves tolerance for GIT commit analysis failures.
When GIT range analysis crashes, the entire record is discarded. The record's
affected[]may contain other non-GIT events (i.e.packageentries) that will be of value.There are two known scenarios where GIT range analysis crashes:
Includes a test to confirm behaviour