perf: do string operations fast #527
Open
+100
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
linting/prefer-fast-strings
branch
from
599afc6 to
e031021
Compare
G-Rath
force-pushed
the
linting/prefer-fast-strings
branch
from
e031021 to
a34b719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that certain string operators are performed using the fastest method possible, based on benchmarks - while in most cases these are not likely to be the slowest component, since the linter can be enforced and automatically fix it's findings, we shouldn't have to worry over it.
As a bonus, switching to using
errors.Newmeans we should be able to better lint error messages in the future.Relates to #274