refactor: ensure there is a newline before returns and branch statements #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
linting/newline-before-returns
branch
from
2c39ad4 to
6b8e65d
Compare
|
I'm not too enthusiastic about this lint, especially because of the number of files changed, and it is very likely to break for internal PRs where it is harder to view the github lint, and it doesn't really solve anything too important. I think we should just ignore this lint. |
G-Rath
force-pushed
the
linting/newline-before-returns
branch
from
6b8e65d to
a44fa5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generally considered to improve readability by making it easier to spot when the control flow is changing
Relates to #274