Skip to content

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 4, 2025

As none of these parameters are used by their respective functions, they can be safely removed without issue.

In the long run the unparam linter will help catch this for us.

Relates to #274

@G-Rath G-Rath force-pushed the refactor/remove-unused-params branch from ea9395f to 71b70bc Compare March 5, 2025 18:47
@G-Rath G-Rath force-pushed the refactor/remove-unused-params branch from 71b70bc to 9e0731c Compare March 6, 2025 01:35
@copybara-service copybara-service bot merged commit 82c912f into google:main Mar 10, 2025
10 checks passed
@G-Rath
Copy link
Collaborator Author

G-Rath commented Mar 10, 2025

fwiw it looks like a new unused param slipped through in #516 but I can get that in the PR that enables unparam once #519 is merged

fuzzychick pushed a commit to fuzzychick/osv-scalibr that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants