chore: ignore nilerr violations relating to linux process extractor
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooryx
approved these changes
Mar 3, 2025
vpasdf
reviewed
Mar 3, 2025
| @@ -94,6 +94,7 @@ func readFileDescriptors(ctx context.Context, d fs.DirEntry, inodesToPID map[int | |||
| // only read PID directories | |||
| pid, err := strconv.ParseInt(d.Name(), 10, 64) | |||
| if err != nil { | |||
| //nolint:nilerr // only read PID directories | |||
There was a problem hiding this comment.
I'd rather remove this lint check, than adding exceptions. I think not passing on the error is totally fine in some cases.
There was a problem hiding this comment.
How do you know though that it is totally fine to be doing so without a comment explaining why it's fine for readers and reviewers? and then, if you're writing a comment to explain that anyway, it doesn't seem costly to prefix that comment with //nolint:nilerr //...
another-rex
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think my understanding here is correct enough, though I feel like ideally
extractSocketInodeshould be returning a sentinel error rather than 0 (which I assume is being used as it is the sentinel value used by Linux to indicate there isn't an inode); in addition to that requiring a bit more code, I figure it might be possible for the function to end up with 0 anyway meaning we couldn't just get rid of theinode != 0...Ultimately, I'm just looking to get CI green again so happy to go in whatever direction(s) others would prefer (including what's written in the comments)