feat: indicate whether a dependency is direct in pomxmlnet extractor #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvarga
reviewed
Feb 28, 2025
| @@ -22,6 +22,7 @@ type Metadata struct { | |||
| Type string | |||
| Classifier string | |||
| DepGroupVals []string | |||
| IsDirect bool // Only set in pomxmlnet extractor | |||
There was a problem hiding this comment.
Also add this to the proto format:
osv-scalibr/binary/proto/scan_result.proto
Line 418 in 5926821
Incl. the conversion in proto.go
And then regenerate scan_result.pb.go with "make protos"
There was a problem hiding this comment.
done - however, do we want to use specific version of protoc?
|
I may hold this PR for some time considering that there are discussions on use cases of the transitive extractor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field to Java's metadata to indicate whether a dependency is direct or not. Currently this is only set in
pomxmlnetextractor.