refactor: remove unused functions and variables #499
+3
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
reviewed
Feb 27, 2025
| depParent = depTypeWithOrigin("parent") | ||
| depPlugin = depTypeWithOrigin("[email protected]:plugin") | ||
| depProfileOne = depTypeWithOrigin("profile@profile-one") | ||
| depProfileTwoMgmt = depTypeWithOrigin("profile@profile-two@management") |
There was a problem hiding this comment.
I think these will be needed when we gradually migrate guided remediation, but we can add them back anyway, so I am fine with removing them. for other changes, I will let @erikvarga to take a look.
erikvarga
reviewed
Feb 28, 2025
| @@ -584,21 +584,6 @@ func TestChainFSReadDir(t *testing.T) { | |||
| // CHAINLAYER TESTING HELPER METHODS | |||
| // ======================================================== | |||
|
|
|||
| func checkError(t *testing.T, funcName string, gotErr error, wantErr error) { | |||
There was a problem hiding this comment.
@another-rex do we need these for layer extraction?
There was a problem hiding this comment.
No I don't think so, and I think we would want to use cmp.Diff instead anyway I believe.
G-Rath
force-pushed
the
linting/enable-unused
branch
from
dab9dc9 to
5d8c75b
Compare
G-Rath
force-pushed
the
linting/enable-unused
branch
from
5d8c75b to
f908d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
unusedlinter, which reports functions and variables that are not being used, of which we have a fair amount - I'm hoping that none of these are used by internal magic, but I'm expecting at least probably is...Relates to #274