refactor: use official semantic package instead of vendored version
#496
+8
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
approved these changes
Feb 27, 2025
vpasdf
reviewed
Feb 28, 2025
G-Rath
force-pushed
the
refactor/use-semantic
branch
from
b4b7d56 to
8da8880
Compare
another-rex
approved these changes
Mar 6, 2025
G-Rath
force-pushed
the
refactor/use-semantic
branch
from
8da8880 to
93677bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have any context on the "why" behind this, but now that
semanticis officially part ofosv-scalibrwe can switch this to using that.For now I have used
panicto handle the possible error as that matches the oldsemanticbehaviour, but am happy to do a follow-up PR switching the surrounding implementation to handle the error more gracefully if folks like (though it shouldn't actually be possible with the Packagist parser)