chore: ensure that JSON errors are properly checked when required #468
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
approved these changes
Feb 18, 2025
erikvarga
reviewed
Feb 26, 2025
G-Rath
force-pushed
the
linting/enable-errchkjson
branch
from
1ab1082 to
1043a3e
Compare
G-Rath
commented
Feb 27, 2025
| @@ -174,6 +174,7 @@ func checkLogin(ctx context.Context, fileBrowserIP string, fileBrowserPort int) | |||
| client := &http.Client{Timeout: requestTimeout} | |||
| targetURL := fmt.Sprintf("http://%s:%d/api/login", fileBrowserIP, fileBrowserPort) | |||
|
|
|||
| //nolint:errchkjson // this is a static struct, so it cannot fail | |||
G-Rath
force-pushed
the
linting/enable-errchkjson
branch
2 times, most recently
from
5e71e30 to
17f3363
Compare
G-Rath
force-pushed
the
linting/enable-errchkjson
branch
from
17f3363 to
8a0daa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #274