Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable misspell linter #263

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Nov 5, 2024

Enabling this linter actually only caught "choosen" but I also ran my IDEs spell/grammer checker which found a few more things

Relates to #152
Relates to #274

@G-Rath G-Rath marked this pull request as draft November 5, 2024 19:05
Copy link
Collaborator

@erikvarga erikvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, will approve once we have an issue for the TODOs (to make internal submission easier)

@G-Rath G-Rath force-pushed the linting/enable-misspell branch from bcfbc69 to 1c63fd7 Compare November 14, 2024 19:33
@G-Rath G-Rath marked this pull request as ready for review November 14, 2024 19:33
@G-Rath G-Rath requested a review from erikvarga November 14, 2024 19:33
@G-Rath G-Rath mentioned this pull request Nov 14, 2024
46 tasks
@copybara-service copybara-service bot merged commit 71e6ff6 into google:main Nov 18, 2024
4 of 6 checks passed
@G-Rath G-Rath deleted the linting/enable-misspell branch November 19, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants