install go1.17 for KubeEdge when building fuzzers #8901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@vincentgoat instead of using an old base builder image, could KubeEdge just install an older version of Go? Like here: |
|
Yes sure, I will take it a try, thx. |
vincentgoat
force-pushed
the
support-go1.17
branch
from
812c958 to
32019d2
Compare
vincentgoat
changed the title
vincentgoat
changed the title
|
@AdamKorcz PTAL |
|
It seems to work well. Juts the CLA is missing, and we can merge this. |
vincentgoat
force-pushed
the
support-go1.17
branch
from
32019d2 to
e5e96e0
Compare
|
CLA has been done. |
|
/hold I will test one more case. |
Signed-off-by: vincentgoat <[email protected]>
vincentgoat
force-pushed
the
support-go1.17
branch
from
e5e96e0 to
3d2a933
Compare
|
/unhold |
AdamKorcz
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vincentgoat [email protected]
install go1.17 for KubeEdge when building fuzzers
Fix issue cncf/cncf-fuzzing#232
cc @AdamKorcz