chronos: add stop-on-failure option for run_tests.sh check #14147
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Korczynski <[email protected]>
|
/gcbrun skip |
AdamKorcz
approved these changes
Oct 22, 2025
AdamKorcz
pushed a commit
that referenced
this pull request
Oct 22, 2025
This test is failing:
```
2025-10-22T11:22:41.3281026Z infra/cifuzz/clusterfuzz_deployment_test.py::OSSFuzzTest::test_download_corpus_fail
2025-10-22T11:22:41.5307008Z [gw1] [100%] PASSED infra/cifuzz/clusterfuzz_deployment_test.py::OSSFuzzTest::test_download_corpus_fail
2025-10-22T11:22:41.5307534Z
2025-10-22T11:22:41.5307675Z =================================== FAILURES ===================================
2025-10-22T11:22:41.5308133Z ____________________ OSSFuzzTest.test_download_latest_build ____________________
2025-10-22T11:22:41.5308719Z [gw0] linux -- Python 3.11.13 /opt/hostedtoolcache/Python/3.11.13/x64/bin/python
2025-10-22T11:22:41.5309091Z
2025-10-22T11:22:41.5309389Z self = <clusterfuzz_deployment_test.OSSFuzzTest testMethod=test_download_latest_build>
2025-10-22T11:22:41.5310070Z mock_download_and_unpack_zip = <MagicMock name='download_and_unpack_zip' id='139924587996176'>
2025-10-22T11:22:41.5310463Z
2025-10-22T11:22:41.5310678Z @mock.patch('http_utils.download_and_unpack_zip', return_value=True)
2025-10-22T11:22:41.5311184Z def test_download_latest_build(self, mock_download_and_unpack_zip):
2025-10-22T11:22:41.5311707Z """Tests that downloading the latest build works as intended under normal
2025-10-22T11:22:41.5312119Z circumstances."""
2025-10-22T11:22:41.5312449Z self.assertEqual(self.deployment.download_latest_build(),
2025-10-22T11:22:41.5312845Z EXPECTED_LATEST_BUILD_PATH)
2025-10-22T11:22:41.5313313Z expected_url = ('https://storage.googleapis.com/clusterfuzz-builds/example/'
2025-10-22T11:22:41.5313790Z 'example-address-202008030600.zip')
2025-10-22T11:22:41.5314325Z > mock_download_and_unpack_zip.assert_called_with(expected_url,
2025-10-22T11:22:41.5314986Z EXPECTED_LATEST_BUILD_PATH)
2025-10-22T11:22:41.5315228Z
2025-10-22T11:22:41.5315424Z infra/cifuzz/clusterfuzz_deployment_test.py:118:
2025-10-22T11:22:41.5316006Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
2025-10-22T11:22:41.5316248Z
2025-10-22T11:22:41.5316451Z self = <MagicMock name='download_and_unpack_zip' id='139924587996176'>
2025-10-22T11:22:41.5317246Z args = ('https://storage.googleapis.com/clusterfuzz-builds/example/example-address-202008030600.zip', '/workspace/cifuzz-prev-build')
2025-10-22T11:22:41.5317938Z kwargs = {}
2025-10-22T11:22:41.5318613Z expected = call('https://storage.googleapis.com/clusterfuzz-builds/example/example-address-202008030600.zip', '/workspace/cifuzz-prev-build')
2025-10-22T11:22:41.5319737Z actual = call('https://storage.googleapis.com/clusterfuzz-builds/example/example-address-202510220616.zip', '/workspace/cifuzz-prev-build')
2025-10-22T11:22:41.5320543Z _error_message = <function NonCallableMock.assert_called_with.<locals>._error_message at 0x7f42bb573560>
2025-10-22T11:22:41.5320970Z cause = None
2025-10-22T11:22:41.5321076Z
2025-10-22T11:22:41.5321193Z def assert_called_with(self, /, *args, **kwargs):
2025-10-22T11:22:41.5321550Z """assert that the last call was made with the specified arguments.
2025-10-22T11:22:41.5321852Z
2025-10-22T11:22:41.5322116Z Raises an AssertionError if the args and keyword args passed in are
2025-10-22T11:22:41.5322462Z different to the last call to the mock."""
2025-10-22T11:22:41.5322729Z if self.call_args is None:
2025-10-22T11:22:41.5323020Z expected = self._format_mock_call_signature(args, kwargs)
2025-10-22T11:22:41.5323362Z actual = 'not called.'
2025-10-22T11:22:41.5323681Z error_message = ('expected call not found.\nExpected: %s\n Actual: %s'
2025-10-22T11:22:41.5324372Z % (expected, actual))
2025-10-22T11:22:41.5324648Z raise AssertionError(error_message)
2025-10-22T11:22:41.5324881Z
2025-10-22T11:22:41.5325051Z def _error_message():
2025-10-22T11:22:41.5325455Z msg = self._format_mock_failure_message(args, kwargs)
2025-10-22T11:22:41.5325905Z return msg
2025-10-22T11:22:41.5326180Z expected = self._call_matcher(_Call((args, kwargs), two=True))
2025-10-22T11:22:41.5326515Z actual = self._call_matcher(self.call_args)
2025-10-22T11:22:41.5326780Z if actual != expected:
2025-10-22T11:22:41.5327071Z cause = expected if isinstance(expected, Exception) else None
2025-10-22T11:22:41.5327427Z > raise AssertionError(_error_message()) from cause
2025-10-22T11:22:41.5327742Z E AssertionError: expected call not found.
2025-10-22T11:22:41.5328433Z E Expected: download_and_unpack_zip('https://storage.googleapis.com/clusterfuzz-builds/example/example-address-202008030600.zip', '/workspace/cifuzz-prev-build')
2025-10-22T11:22:41.5329500Z E Actual: download_and_unpack_zip('https://storage.googleapis.com/clusterfuzz-builds/example/example-address-202510220616.zip', '/workspace/cifuzz-prev-build')
```
I don't know much about this code, but it's currently blocking other
`infra/` PRs to be submitted e.g.
#14173 and
#14147
Am silencing this for now as I'm not sure what caused the dates to
change.
Signed-off-by: David Korczynski <[email protected]>
|
/gcbrun skip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.