Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensk: Fix build #12013

Merged
merged 1 commit into from
May 29, 2024
Merged

opensk: Fix build #12013

merged 1 commit into from
May 29, 2024

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented May 29, 2024

Needed because of #11626 (comment)

Copy link

maflcko is a new contributor to projects/opensk. The PR must be approved by known contributors before it can be merged. The past contributors are: kaczmarczyck, ia0, catenacyber, jmichelp

@maflcko
Copy link
Contributor Author

maflcko commented May 29, 2024

cc @kaczmarczyck

Copy link
Contributor

@kaczmarczyck kaczmarczyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

Out of curiosity: I assume this toolchain downgrade requirement might become obsolete eventually?

@maflcko
Copy link
Contributor Author

maflcko commented May 29, 2024

Yes, it can be bumped or removed in the future. But there are some blockers that need to be fixed first.

@DavidKorczynski DavidKorczynski merged commit 2149bb8 into google:master May 29, 2024
16 checks passed
@maflcko maflcko deleted the 2405-opensk branch May 30, 2024 11:24
@kaczmarczyck
Copy link
Contributor

Confirming this fixed the build problem:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=69138#c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants