Add handling for empty response #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
|
/gcbrun exp -n ascc-pr-808-1 -m vertex_ai_gemini-1-5 -i -b comparison |
|
/gcbrun exp -n ascc-pr-808-2 -m vertex_ai_gemini-1-5 -i -b comparison |
DavidKorczynski
requested changes
Mar 3, 2025
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
fix-empty-response-re-error
branch
from
88c155d to
bd89509
Compare
|
/gcbrun exp -n ascc-pr-808-3 -m vertex_ai_gemini-1-5 -i -b comparison |
DavidKorczynski
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the llm may fail to generate any response (maybe timeout or connection issues), it will result in None response and that creates an error when it is passed in for regular expression tag parsing. This PR fixes that by ensuring response is not None before passing in to process.