experimental: add post-processing logic #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Korczynski <[email protected]>
|
Sample run: |
|
/gcbrun skip |
DonggeLiu
approved these changes
Jul 7, 2024
| LOG_FMT = '[%(filename)s:%(lineno)d]: %(message)s' | ||
|
|
||
|
|
||
| def _get_edge_cov_from_line(line: str) -> Optional[int]: |
There was a problem hiding this comment.
A regex for the same purpose:
oss-fuzz-gen/experiment/builder_runner.py
Line 327 in 350333b
Feel free to use either.
There was a problem hiding this comment.
Will do this in a similar fashion as mentioned in #440 (comment)
|
|
||
| def oss_fuzz_out_dir(oss_fuzz_dir: str) -> str: | ||
| """Returns the out folder of a given OSS-Fuzz repository.""" | ||
| return os.path.join(oss_fuzz_dir, 'build', 'out') |
There was a problem hiding this comment.
This function is quite generally useful, how about relocating it to oss_fuzz_checkout.py, where we store all OSS-Fuzz-related functions? (e.g., if so, please also consider removing oss_fuzz in the function name to avoid stuttering, e.g., get_out_dir() or out_dir() as a @property)
There was a problem hiding this comment.
Good point. I'll leave this for now as this PR is in a bit grander-scheme an effort to prepare for merging the codebases #450 -- A larger PR will come in the near future that does this on a more rigorous level so will do this at that point
Signed-off-by: David Korczynski <[email protected]>
|
/gcbrun skip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to easily digest the results from a larger scale run