comments

google · May 8, 2024 · 6bc3046 · 6bc3046
1 parent 0dc373c
commit 6bc3046
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/llm_toolkit/code_fixer.py b/llm_toolkit/code_fixer.py
@@ -256,7 +256,7 @@ def extract_error_message(log_path: str,
     if found_keyword:
       continue
 
-    # Add clang diagnostics.
+    # Add clang/clang++ diagnostics.
     if (temp_range[0] is None and (re.fullmatch(error_include_pattern, line) or
                                    re.fullmatch(error_start_pattern, line))):
       temp_range[0] = i

diff --git a/llm_toolkit/prompt_builder.py b/llm_toolkit/prompt_builder.py
@@ -298,6 +298,8 @@ def _format_fixer_problem(self, raw_code: str, error_desc: Optional[str],
     selected_errors = []
     for error in errors:
       # Skip C only errors.
+      # TODO(Dongge): Fix JCC to address this.
+      # https://github.com/google/oss-fuzz-gen/pull/208/files/a0c0db2fd5860e6e4d434467c5ec9f949ee2cff1#r1571651507
       if (FALSE_EXTERN_KEYWORD_ERROR in error or
           FALSE_FUZZED_DATA_PROVIDER_ERROR in error):
         continue