Add BSA label to rdap-domain 404 responses for BSA domains #2706
Conversation
There was a problem hiding this comment.
Reviewed 9 of 17 files at r1.
Reviewable status: 9 of 17 files reviewed, 1 unresolved discussion
core/src/main/java/google/registry/rdap/RdapIcannStandardInformation.java line 70 at r1 (raw file):
Notice.builder() .setTitle("Blocked Domain") .setDescription("This name has been blocked by a GlobalBlock service")
Can we use the template in the config file?
Code quote:
.setDescription("This name has been blocked by a GlobalBlock service")
There was a problem hiding this comment.
Reviewable status: 9 of 17 files reviewed, 1 unresolved discussion (waiting on @weiminyu)
core/src/main/java/google/registry/rdap/RdapIcannStandardInformation.java line 70 at r1 (raw file):
Previously, weiminyu (Weimin Yu) wrote…
Can we use the template in the config file?
hmm, originally I was reluctant to do that because of the combination of "that string isn't quite suitable for a JSON object" and "it seems silly to have two separate config points for BSA messaging" but I suppose the first one will go away once WHOIS is removed.
There was a problem hiding this comment.
Reviewable status: 9 of 17 files reviewed, 1 unresolved discussion (waiting on @weiminyu)
core/src/main/java/google/registry/rdap/RdapIcannStandardInformation.java line 70 at r1 (raw file):
Previously, gbrodman wrote…
hmm, originally I was reluctant to do that because of the combination of "that string isn't quite suitable for a JSON object" and "it seems silly to have two separate config points for BSA messaging" but I suppose the first one will go away once WHOIS is removed.
oh right, the practical reasoning was also that this is a private static var so injecting the config value is nontrivial -- thoughts?
This change is