Use sql instance name in SecretManager #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiminyu
force-pushed
the
use-sql-instance-in-secretmanager
branch
from
5dc6560 to
523b2a0
Compare
jianglai
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @weiminyu)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
weiminyu
force-pushed
the
use-sql-instance-in-secretmanager
branch
from
523b2a0 to
7f770db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested: In crash, deployed the nomulus server, and tested the get_sql_credential command.
Note: new SecretManager entries have been added in all environments.
This change is