Make GKE the default in alpha and qa #2624
Merged
+66
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianglai
force-pushed
the
alpha-gke-default
branch
from
adcaabf to
c7733c1
Compare
jianglai
commented
Dec 16, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
jianglai
force-pushed
the
alpha-gke-default
branch
from
c7733c1 to
f8dcc3c
Compare
weiminyu
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
jianglai
force-pushed
the
alpha-gke-default
branch
from
f8dcc3c to
b87e5e0
Compare
jianglai
commented
Dec 17, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nomulustool talks to the GKE endpoints by default in alpha and QA. Use--gaeto override.Updates
:jetty:deployNomulusto deploy Cloud Scheduler tasks (targeting GKE endpoints) and Cloud Tasks queues.Update proxy to determine whether it is canary from the environment variable itself, instead of from a different flag in the config file.
TESTED=
Deployed to alpha, tested using
nomulustool to connect to GKE/GAE and canary/non-canary endpointsDeployed proxy to QA, used
whoisfrom command line to verify it reaches GKE canary/non-canary endpoints correctly.This change is