Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase CreateCdnsTld DNSSEC params #2607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jicelhay
Copy link
Collaborator

@jicelhay jicelhay commented Nov 7, 2024

From here https://cloud.google.com/dns/docs/reference/rest/v1/managedZones#ManagedZone.DnsSecConfig

Allowed values for state in ["off", "on", "transfer"];
Allowed values for nonExistence in ["nsec", "nsec3"];

Currently getting the following errors when using this command:

"errors": [
{
"message": "Invalid value at 'managed_zone.dnssec_config.non_existence' (type.googleapis.com/cloud.dns.api.v1.NonExistenceType), "NSEC"\nInvalid value at 'managed_zone.dnssec_config.state' (type.googleapis.com/cloud.dns.api.v1.ManagedZone.DnsSecConfig.State), "ON"",
"reason": "invalid"
}
],


This change is Reviewable

@jicelhay jicelhay assigned jicelhay and jianglai and unassigned jicelhay and jianglai Nov 7, 2024
@jicelhay jicelhay requested a review from jianglai November 7, 2024 22:41
Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jicelhay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants