Skip to content

Commit

Permalink
Remove List{Domains,Hosts} commands
Browse files Browse the repository at this point in the history
These commands have been broken for a long time due to result sizes.

We can enhance them by pagination. However, since no one has requested
a fix, removal makes more sense.
  • Loading branch information
weiminyu committed Sep 9, 2024
1 parent 4d3dec5 commit 272b517
Show file tree
Hide file tree
Showing 11 changed files with 1 addition and 585 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@
import google.registry.tmch.TmchSmdrlAction;
import google.registry.tools.server.CreateGroupsAction;
import google.registry.tools.server.GenerateZoneFilesAction;
import google.registry.tools.server.ListDomainsAction;
import google.registry.tools.server.ListHostsAction;
import google.registry.tools.server.ListPremiumListsAction;
import google.registry.tools.server.ListRegistrarsAction;
import google.registry.tools.server.ListReservedListsAction;
Expand Down Expand Up @@ -225,10 +223,6 @@ interface RequestComponent {

IcannReportingUploadAction icannReportingUploadAction();

ListDomainsAction listDomainsAction();

ListHostsAction listHostsAction();

ListPremiumListsAction listPremiumListsAction();

ListRegistrarsAction listRegistrarsAction();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
import google.registry.request.RequestScope;
import google.registry.tools.server.CreateGroupsAction;
import google.registry.tools.server.GenerateZoneFilesAction;
import google.registry.tools.server.ListDomainsAction;
import google.registry.tools.server.ListHostsAction;
import google.registry.tools.server.ListPremiumListsAction;
import google.registry.tools.server.ListRegistrarsAction;
import google.registry.tools.server.ListReservedListsAction;
Expand All @@ -56,8 +54,6 @@ public interface ToolsRequestComponent {
CreateGroupsAction createGroupsAction();
EppToolAction eppToolAction();
GenerateZoneFilesAction generateZoneFilesAction();
ListDomainsAction listDomainsAction();
ListHostsAction listHostsAction();
ListPremiumListsAction listPremiumListsAction();
ListRegistrarsAction listRegistrarsAction();
ListReservedListsAction listReservedListsAction();
Expand Down
60 changes: 0 additions & 60 deletions core/src/main/java/google/registry/tools/ListDomainsCommand.java

This file was deleted.

28 changes: 0 additions & 28 deletions core/src/main/java/google/registry/tools/ListHostsCommand.java

This file was deleted.

2 changes: 0 additions & 2 deletions core/src/main/java/google/registry/tools/RegistryTool.java
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ public final class RegistryTool {
.put("ghostryde", GhostrydeCommand.class)
.put("hash_certificate", HashCertificateCommand.class)
.put("list_cursors", ListCursorsCommand.class)
.put("list_domains", ListDomainsCommand.class)
.put("list_feature_flags", ListFeatureFlagsCommand.class)
.put("list_hosts", ListHostsCommand.class)
.put("list_premium_lists", ListPremiumListsCommand.class)
.put("list_registrars", ListRegistrarsCommand.class)
.put("list_reserved_lists", ListReservedListsCommand.class)
Expand Down

This file was deleted.

30 changes: 0 additions & 30 deletions core/src/test/java/google/registry/tools/ListHostsCommandTest.java

This file was deleted.

Loading

0 comments on commit 272b517

Please sign in to comment.