-
Notifications
You must be signed in to change notification settings - Fork 331
feat: add annotation schema tab to annotation panel and editable properties for annotations #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Aigul Zhyldyzbekova <[email protected]> Co-authored-by: Chris Jordan <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@chrisj sorry perhaps I used the wrong email? I think the CLA passed with that email before, so apologies there if I have the wrong one. |
This looks very cool! I'm excited to try it out. One thing I've always wished for (for local annotations) is the ability to edit the annotation position itself. Is that possible with this PR? For box and (especially) ellipsoid annotations, I find it tricky to manipulate the extents exactly how I want using the UI alone. The ability to fine-tune the position with my keyboard would be nice. One other feature (probably out of scope for this PR) would be to optionally change the annotation type: For lines and boxes, the points remain the same. Transforming to/from ellipsoids requires a trivial calculation. |
Thanks for the suggestions! I opened the first as an issue with some ideas for now |
feat: make bool a real annotation type
fix: watch for scroll on color
feat: create an enum default select
@seankmartin I think you need to rebase to get the mac tests to pass.. @chrisj has got the CLA agreement fixed. |
Readonly datasources get a readonly view of the schema. Editable datasources (e.g. local annotation layers) get an editable version of the schema to add properties to. Editable datasources can also modify properties of annotations from the selection panel.