Skip to content

Conversation

seankmartin
Copy link
Contributor

Readonly datasources get a readonly view of the schema. Editable datasources (e.g. local annotation layers) get an editable version of the schema to add properties to. Editable datasources can also modify properties of annotations from the selection panel.

image image

Co-authored-by: Aigul Zhyldyzbekova <[email protected]>
Co-authored-by: Chris Jordan <[email protected]>
Copy link

google-cla bot commented Jul 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@seankmartin
Copy link
Contributor Author

@chrisj sorry perhaps I used the wrong email? I think the CLA passed with that email before, so apologies there if I have the wrong one.

@stuarteberg
Copy link
Contributor

This looks very cool! I'm excited to try it out.

One thing I've always wished for (for local annotations) is the ability to edit the annotation position itself. Is that possible with this PR?

For box and (especially) ellipsoid annotations, I find it tricky to manipulate the extents exactly how I want using the UI alone. The ability to fine-tune the position with my keyboard would be nice.

One other feature (probably out of scope for this PR) would be to optionally change the annotation type: For lines and boxes, the points remain the same. Transforming to/from ellipsoids requires a trivial calculation.

@seankmartin
Copy link
Contributor Author

Thanks for the suggestions! I opened the first as an issue with some ideas for now

@seankmartin seankmartin marked this pull request as ready for review September 22, 2025 12:19
@fcollman
Copy link
Contributor

fcollman commented Oct 6, 2025

@seankmartin I think you need to rebase to get the mac tests to pass.. @chrisj has got the CLA agreement fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants