fix: fix symbol checking and creation for subst with a regexp
#906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
fix-multiple-subst-regexp-calls
branch
from
b69e260
to
29ca98a
Compare
terencehonles
force-pushed
the
fix-multiple-subst-regexp-calls
branch
from
29ca98a
to
bae620f
Compare
jaqx0r
suggested changes
Aug 7, 2024
This change updates the ``checkRegex`` helper to not track symbols for a regexp when it is used by the builtin ``subst``. In this case the VM will not store these matches, and therefore these symbols will not be available to the program. The compiler will, however, compile these regexp and add them to the regexp table for use by the VM, and multiple calls to ``subst`` are already handled by the VM. fixes: google#693, google#810
terencehonles
force-pushed
the
fix-multiple-subst-regexp-calls
branch
from
bae620f
to
c7ba9c4
Compare
terencehonles
changed the title
subst with a regexpsubst with a regexp
jaqx0r
approved these changes
Aug 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 57.52% 57.57% +0.04%
==========================================
Files 68 68
Lines 6908 6915 +7
==========================================
+ Hits 3974 3981 +7
Misses 2669 2669
Partials 265 265 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
checkRegexhelper to not track symbols for a regexp when it is used by the builtinsubst. In this case the VM will not store these matches, and therefore these symbols will not be available to the program. The compiler will, however, compile these regexp and add them to the regexp table for use by the VM, and multiple calls tosubstare already handled by the VM.fixes: #693, fixes: #810