fix: Use context cancellation instead of Stop to stop streams.
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We handle their shutdown with fs.Stop().
This means a stream will shut itself down and does not need the tailer to instruct it to do so. It thus avoids a race when the tailer doesn't know if the stream has performed enough reads. We need to separate the meaning of oneShot mode and streamFromStart as the former tells us how to exit a stream, and the latter tells us how to start reading a new file after log rotation.
In this mode we merely tell datagrams to exit when a zero byte read occurs in oneshot mode. This is the same as before except we must also explicitly tell the stream to do it in this mode.
Remove the stop channel, use a local context. Fix up one test.
Fix up the test to not need cancellation for oneshot mode.
Unit Test Results 1 files 27 suites 8m 29s ⏱️ Results for commit 3d4fdba. ♻️ This comment has been updated with latest results. |
We don't use the contexts in struct anyway, so this is neater. Fixes a lint warning.
jaqx0r
force-pushed
the
logstream-context-cancellation
branch
from
e2f24b1
to
3d4fdba
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the interface for stream shutdown, though we can't remove
Stopcompletely yet.Also fixes
oneShothandling in various streams.Issue: #199