Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove excessive TAB in one import statement #827

Merged
merged 1 commit into from
Mar 26, 2024
Merged

chore: Remove excessive TAB in one import statement #827

merged 1 commit into from
Mar 26, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 26, 2024

This PR fixes the formatting of import statements in one file.

Details

The PR arose when I ran gci linter and found that this tool broke on imports with TABS at the end:

❯ gci diff internal/mtail/mtail.go
Error: 26:42: expected ';', found "go.opencensus.io/zpages" (and 7 more errors)

But when I remove this TAB thegci working fine:

❯ gci diff internal/mtail/mtail.go
--- internal/mtail/mtail.go
+++ internal/mtail/mtail.go
@@ -21,8 +21,8 @@
        "github.com/google/mtail/internal/tailer"
        "github.com/prometheus/client_golang/prometheus"
        "github.com/prometheus/client_golang/prometheus/collectors"
-       "github.com/prometheus/client_golang/prometheus/promhttp"
        vc "github.com/prometheus/client_golang/prometheus/collectors/version"
+       "github.com/prometheus/client_golang/prometheus/promhttp"
        "github.com/prometheus/common/version"
        "go.opencensus.io/zpages"
 )

@alexandear alexandear requested a review from jaqx0r as a code owner March 26, 2024 14:20
@jaqx0r
Copy link
Contributor

jaqx0r commented Mar 26, 2024

Thanks for the fix!

@jaqx0r jaqx0r enabled auto-merge March 26, 2024 20:18
@jaqx0r jaqx0r added this pull request to the merge queue Mar 26, 2024

This comment has been minimized.

Merged via the queue into google:main with commit 7b1512a Mar 26, 2024
15 checks passed
Copy link
Contributor

Unit Test Results

       1 files  ±0       27 suites  ±0   8m 43s ⏱️ -1s
   645 tests ±0     644 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
1 908 runs  ±0  1 905 ✔️ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 7b1512a. ± Comparison against base commit d62c117.

@alexandear alexandear deleted the remove-excessive-tab branch March 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants