This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Better handling of Unnecessary Parentheses #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Gabriel, As I noted when you opened your first PR, I'm not really prioritizing this project right now and don't have bandwidth to review PRs and update the package and etc. I really appreciate your interest in this project!! But for now it would be easiest if you forked it to get the changes you want to make. Sorry for the inconvenience |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #251 and #250 , using @xZGit's suggestion in #251 (comment) to just use the root argument of
removeUnnecessaryParensThis also undos the lib changes in #250 which no longer seem necessary