Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor phone context parsing for RFC3966 numbers. #3780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor phone context parsing for RFC3966 numbers. #3780

wants to merge 1 commit into from

Conversation

silvio2402
Copy link
Collaborator

@silvio2402 silvio2402 commented Jan 10, 2025 •
edited
Loading

  • Refactor the logic to extract the phone context from an RFC3966 URI to a new PhoneContextParser class.
  • Refactor the number normalization methods normalizeDigits and normalizeDigitsOnly to a new PhoneNumberNormalizer class.

    This keeps PhoneNumberUtil.normalizeDigitsOnly as a shell because it is public.

  • Move the constants that are common between PhoneContextParser and PhoneNumberUtil to a new Constants class.

This is a refactor and should not change the logic of the parser.

Context: b/370922064

@silvio2402 silvio2402 requested a review from tvislavski January 10, 2025 16:53
@silvio2402 silvio2402 requested a review from a team as a code owner January 10, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvislavski tvislavski Awaiting requested review from tvislavski

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@silvio2402