ollama: send keep_alive at top level #267
Open
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #256 This PR aligns the Ollama provider with the Ollama API by sending keep_alive at the payload’s top level while keeping options.keep_alive for backward compatibility.
Changes
Provider: compute keep_alive once, set payload['keep_alive'] and options['keep_alive'].
Tests: in tests/inference_test.py:
test_ollama_extra_kwargs_passed_to_api: assert payload['keep_alive'] == 600.
test_ollama_defaults_when_unspecified: assert payload['keep_alive'] == 300.
Compatibility
Backward-compatible: options.keep_alive is still present. No breaking API changes.