Cleanup the build scripts and update to Gradle 8.10 #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansman
force-pushed
the
chore/cleanup-gradle
branch
from
3edf678
to
409c5c5
Compare
hfhbd
reviewed
Sep 2, 2024
gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspSubplugin.kt
Outdated
Show resolved
Hide resolved
ansman
commented
Sep 4, 2024
ansman
commented
Sep 4, 2024
ansman
commented
Sep 4, 2024
ansman
commented
Sep 6, 2024
|
Is this blocked by anything? I'm hoping it will be merged soon so I can rebase this PR on top of it. |
ting-yuan
approved these changes
Sep 26, 2024
|
Sorry I missed the latest push which added test for AGP compatibility. The PR looks perfect to me! Please rebase and I'll merge as soon as possible. |
ansman
force-pushed
the
chore/cleanup-gradle
branch
from
547d69c
to
7b4e438
Compare
|
@scott-pollom this is merged now |
ting-yuan
pushed a commit
to ting-yuan/ksp
that referenced
this pull request
Sep 27, 2024
* Cleanup the build scripts and update to Gradle 8.10 * Fix the CI issues * Remove the debug prints * Update to AGP 8.0.0 * Update to Java 11 source target * Fix all tests * Add a test for AGP 7.3.1 * Fix the test error (cherry picked from commit a8c7e9e)
ting-yuan
added a commit
that referenced
this pull request
Sep 28, 2024
* Cleanup the build scripts and update to Gradle 8.10 * Fix the CI issues * Remove the debug prints * Update to AGP 8.0.0 * Update to Java 11 source target * Fix all tests * Add a test for AGP 7.3.1 * Fix the test error (cherry picked from commit a8c7e9e) Co-authored-by: Nicklas Ansman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.