Delete the ksp caches when the task is restored from cache #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansman
force-pushed
the
fix/2042/incremental-building
branch
from
7d24fdb
to
69a98ec
Compare
ansman
added a commit
to ansman/ksp
that referenced
this pull request
Aug 24, 2024
Without this change, the task's caches will be in an incorrect state and the next incremental run can lead to compile errors. Now the caches have been marked as local state and Gradle will remove them when the task is restored from the build cache. This fixes google#2055
ansman
force-pushed
the
fix/2042/incremental-building
branch
from
69a98ec
to
2d6c302
Compare
Without this change, the task's caches will be in an incorrect state and the next incremental run can lead to compile errors. Now the caches have been marked as local state and Gradle will remove them when the task is restored from the build cache. This fixes google#2042
ansman
force-pushed
the
fix/2042/incremental-building
branch
from
2d6c302
to
035b05f
Compare
oehme
approved these changes
Aug 24, 2024
ting-yuan
approved these changes
Aug 26, 2024
ansman
force-pushed
the
fix/2042/incremental-building
branch
2 times, most recently
from
abd7527
to
035b05f
Compare
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the task's caches will be in an incorrect state and the next incremental run can lead to compile errors.
Now the caches have been marked as local state and Gradle will remove them when the task is restored from the build cache.
This fixes #2042