Skip to content

Enable -Wundef for Bigtop C/ObjC targets and prohibit config.h symbols in Swift.#2770

Open
copybara-service[bot] wants to merge 1 commit into
masterfrom
test_933124158
Open

Enable -Wundef for Bigtop C/ObjC targets and prohibit config.h symbols in Swift.#2770
copybara-service[bot] wants to merge 1 commit into
masterfrom
test_933124158

Conversation

@copybara-service

Copy link
Copy Markdown

Enable -Wundef for Bigtop C/ObjC targets and prohibit config.h symbols in Swift.

  • Add -Werror=undef to _WARNING_UPGRADED_TO_ERROR_FLAGS in bigtop.bzl (only for non-opt builds).
  • Add a presubmit check in METADATA.swift to prohibit using config.h preprocessor symbols in Swift files.
  • Modify J2ObjC generator to use defined() check for J2OBJC_IMPORTED_BY_JAVA_IMPLEMENTATION.

@copybara-service copybara-service Bot force-pushed the test_933124158 branch 2 times, most recently from 2520798 to b18ce68 Compare June 16, 2026 22:19
PiperOrigin-RevId: 933124158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant