Only allow one BrushTip per BrushCoat in interface #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_733341500
branch
2 times, most recently
from
a9ff80b to
066504d
Compare
BrushCoats with multiple or zero tips already failed validation. The intention was eventually to support multiple BrushTips per BrushCoat, but that plan has become disfavored, since the use case can be supported with multiple BrushCoats per BrushFamily. The proto change is technically not backwards compatible, it changes the behavior of decoding old protos encoded with multiple BrushTips per BrushCoat from "fail validation" to "take the last one". However, such a structure wouldn't have worked previously anyways. PiperOrigin-RevId: 733341500
copybara-service
bot
force-pushed
the
test_733341500
branch
from
066504d to
246ab1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow one BrushTip per BrushCoat in interface
BrushCoats with multiple or zero tips already failed validation. The intention was eventually to support multiple BrushTips per BrushCoat, but that plan has become disfavored, since the use case can be supported with multiple BrushCoats per BrushFamily.
The proto change is technically not backwards compatible, it changes the behavior of decoding old protos encoded with multiple BrushTips per BrushCoat from "fail validation" to "take the last one". However, such a structure wouldn't have worked previously anyways.