-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test on Windows MSYS2 #413
base: master
Are you sure you want to change the base?
Conversation
This currently fails in a bunch of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Let's confirm it works after the ulp issues are fixed? I expect to have a fix for that tomorrow.
I'm concerned about the 11m runtime of the x64 builder, that might cause timeouts. Anything we can do to speed it up? |
So, the compilation takes quite a while because it compiles for all 4 targets. The other two clang builders compile only scalar (1m) vs these builders that compile all (5m). We could compile less (like scalar+avx2). I think |
That sounds useful, it should hopefully bring us under 10min?
Ah, makes sense. |
4691ae1
to
fdc0950
Compare
@jan-wassenberg HwyMathTestGroup/HwyMathTest.TestAllAcos segfaults here for |
@deymo hm, if it were an assert failing, we should also be seeing output to stderr (with an extra fflush just in case) from hwy::Abort in targets.cc, right? |
@deymo FYI math_test is now disabled in cmake. |
New GitHub workflow to build and test on a Windows MSYS2 build in 32 and 64 bits. This patch sets the `LANGUAGES` to `CXX` in the cmake project to avoid setting up the `C` language which is not used by the project. Due to a bug in cmake ninja generator with MSYS we can't set a prefix on the target because it creates a duplicated ninja rule.
@jan-wassenberg I rebased it and SortTestGroup/SortTest.TestAllReverse/AVX2 is now failing, and also clang-5 |
New GitHub workflow to build and test on a Windows MSYS2 build in 32 and
64 bits.
This patch sets the
LANGUAGES
toCXX
in the cmake project to avoidsetting up the
C
language which is not used by the project.Due to a bug in cmake ninja generator with MSYS we can't set a prefix on
the target because it creates a duplicated ninja rule.