Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TODO in aligned_allocator #2298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scuzqy
Copy link

@scuzqy scuzqy commented Aug 9, 2024

And updated corresponding test.
AllocateAligned was designed to take POD types only.

I also removed TestAllocateAlignedObjectWithoutDestructor because objects with constructor/destructor are obviously illegal input.
btw, restriction here can be one is_trivial, perhaps?

Copy link

google-cla bot commented Aug 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

And updated corresponding test.
AllocateAligned was designed to take POD types only.
@scuzqy scuzqy force-pushed the AlignedAllocatorPOD branch from df933ce to fa07d18 Compare August 9, 2024 17:50
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants