Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs update #2075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ryo-not-rio
Copy link

Add data types for SetTableIndices and made it clearer on how to load indices for TableLookUpBytes

Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying :) Some suggested updates:

type than those in `V`. The number of lanes in `V` and `VI` may differ, e.g.
a full-length table vector loaded via `LoadDup128`, plus partial vector `VI`
of 4-bit indices.
type than those in `V` and are loaded uses the standard load instructions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loading using?

@@ -1928,16 +1928,16 @@ their operands into independently processed 128-bit *blocks*.

All other ops in this section are only available if `HWY_TARGET != HWY_SCALAR`:

* `V`: `{u,i}` \
* `V`, `VI`: `{u,i}` \
<code>VI **TableLookupBytes**(V bytes, VI indices)</code>: returns
`bytes[indices[i]]`. Uses byte lanes regardless of the actual vector types.
Results are implementation-defined if `indices[i] < 0` or `indices[i] >=
HWY_MIN(Lanes(DFromV<V>()), 16)`. `VI` are integers, possibly of a different
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like "VI are normal vectors with integer lane type possibly differing from the lanes of V. Note that TableLookupLanes has an unspecified, potentially non-vector type type for the indices."?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants