Follow symlinks in MkdirAllAt #11912
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl781612832
branch
7 times, most recently
from
147cabc to
c1b9464
Compare
copybara-service
bot
force-pushed
the
test/cl781612832
branch
12 times, most recently
from
d6a351f to
d213593
Compare
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service
bot
force-pushed
the
test/cl781612832
branch
from
d213593 to
d000539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow symlinks in MkdirAllAt
See #11910 for details — this potentially fixes a divergence between gVisor and
runc behavior where having the
cwdof the OCI container spec set to a symlinkto a folder causes gVisor to exit with this error:
FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1