[exec] Write trailing newline to -pid-file and -internal-pid-file #11901
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl780722929
branch
9 times, most recently
from
075195f to
8217909
Compare
copybara-service
bot
force-pushed
the
test/cl780722929
branch
from
8217909 to
7934a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[exec] Write trailing newline to -pid-file and -internal-pid-file
When executing command, otherwise it is not possible to know when the pid file is fully written.
Resolves #11851
This PR only changes
execcommand, and not other commands that write pid files.FUTURE_COPYBARA_INTEGRATE_REVIEW=#11861 from stepancheg:pid-file 726d8d9