Support and document testing on macOS with CLT #11899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `jq` invocation in 501618d was not correct for macOS and Windows where the first elements were .pkg and .msi packages respectively, neither of which are supported by download_and_extract, resulting in: ``` Error in download_and_extract: Expected a file with a .zip, .jar, .war, .aar, .nupkg, .tar, .tar.gz, .tgz, .tar.xz, , .tar.zst, .tzst, .tar.bz2, .tbz, .ar or .deb suffix (got ...) ``` Update the `jq` command to select only .tar.gz and update the list.
|
@EtiennePerot PTAL |
- Document bazel 7 requirement and how to use it on macOS. - Override `build_bazel_apple_support` to pick up support for CLT-only builds. - Fix nogo CLI build on macOS by using `"golang.org/x/term".IsTerminal` which works around `unix.TCGETS` not being defined there.
tamird
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.