Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling for showing terms of service dialog #3033

Closed
wants to merge 14 commits into from

Add survey to the mapUiCard to prevent downstream logic to re-fetch t…

eeb851e
Select commit
Loading
Failed to load commit list.
Closed

Simplify handling for showing terms of service dialog #3033

Add survey to the mapUiCard to prevent downstream logic to re-fetch t…
eeb851e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 5, 2025 in 1s

64.15% (+0.00%) compared to bc73c41

View this Pull Request on Codecov

64.15% (+0.00%) compared to bc73c41

Details

Codecov Report

Attention: Patch coverage is 15.78947% with 64 lines in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (bc73c41) to head (eeb851e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 3.33% 26 Missing and 3 partials ⚠️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 20.68% 23 Missing ⚠️
...ground/ui/home/mapcontainer/cards/MapCardUiData.kt 0.00% 11 Missing ⚠️
...google/android/ground/repository/UserRepository.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #3033   +/-   ##
=========================================
  Coverage     64.15%   64.15%           
+ Complexity     1266     1265    -1     
=========================================
  Files           270      270           
  Lines          6481     6481           
  Branches        901      902    +1     
=========================================
  Hits           4158     4158           
  Misses         1730     1730           
  Partials        593      593
Files with missing lines Coverage Δ
.../main/java/com/google/android/ground/model/Role.kt 100.00% <100.00%> (+20.00%) ⬆️
...google/android/ground/repository/UserRepository.kt 86.11% <80.00%> (+0.81%) ⬆️
...ground/ui/home/mapcontainer/cards/MapCardUiData.kt 0.00% <0.00%> (ø)
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 41.46% <20.68%> (-4.37%) ⬇️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 17.93% <3.33%> (+0.35%) ⬆️
View more details on Codecov