Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new use case for listing available surveys #3016

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Jan 19, 2025

Towards #3014

This PR aims at pulling out all logic related to compiling a list of surveys to be displayed to the user from SurveyRepositry to a new use case ListAvailableSurveysUseCase.

Also adds test coverage for the new use case.

@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review January 19, 2025 09:00
@auto-assign auto-assign bot requested a review from scolsen January 19, 2025 09:00
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.51%. Comparing base (040cbb5) to head (b0e364d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ain/usecases/survey/ListAvailableSurveysUseCase.kt 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3016      +/-   ##
============================================
+ Coverage     63.42%   63.51%   +0.09%     
- Complexity     1259     1262       +3     
============================================
  Files           269      270       +1     
  Lines          6551     6559       +8     
  Branches        928      929       +1     
============================================
+ Hits           4155     4166      +11     
+ Misses         1794     1789       -5     
- Partials        602      604       +2     
Files with missing lines Coverage Δ
...ogle/android/ground/repository/SurveyRepository.kt 86.48% <ø> (+10.93%) ⬆️
...round/ui/surveyselector/SurveySelectorViewModel.kt 93.61% <100.00%> (ø)
...ain/usecases/survey/ListAvailableSurveysUseCase.kt 93.75% <93.75%> (ø)

... and 1 file with indirect coverage changes

@shobhitagarwal1612 shobhitagarwal1612 merged commit 553abda into master Jan 20, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/3014/new-use-case branch January 20, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants