Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update todo-to-list github action to commit to PR instead of master branch #2943

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Dec 17, 2024

Instead of merging the commit to master branch, it commits to the PR's source branch when the PR is approved.

@gino-m PTAL?

@shobhitagarwal1612 shobhitagarwal1612 force-pushed the test-todo branch 2 times, most recently from 3b7535e to aff28d1 Compare December 17, 2024 13:04
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review December 17, 2024 13:09
@auto-assign auto-assign bot requested a review from gino-m December 17, 2024 13:09
@shobhitagarwal1612 shobhitagarwal1612 changed the title Test todo Update todo-to-list github action to commit to PR instead of master branch Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.54%. Comparing base (b660181) to head (3ac2a5f).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2943   +/-   ##
=========================================
  Coverage     62.54%   62.54%           
  Complexity     1203     1203           
=========================================
  Files           267      267           
  Lines          6357     6357           
  Branches        879      879           
=========================================
  Hits           3976     3976           
  Misses         1831     1831           
  Partials        550      550           

@gino-m
Copy link
Collaborator

gino-m commented Dec 18, 2024

@shobhitagarwal1612 Should we move this to draft for now?

@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as draft December 18, 2024 18:38
@shobhitagarwal1612 shobhitagarwal1612 force-pushed the test-todo branch 4 times, most recently from 0e49ac6 to c9ff361 Compare December 18, 2024 19:16
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review December 18, 2024 19:34
@auto-assign auto-assign bot requested a review from anandwana001 December 18, 2024 19:34
@shobhitagarwal1612 shobhitagarwal1612 removed the request for review from anandwana001 December 18, 2024 19:36
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as draft December 19, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants