Added values in dimens.xml #2937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shobhitagarwal1612
approved these changes
Dec 17, 2024
gino-m
requested changes
Dec 19, 2024
| @@ -39,4 +39,16 @@ | |||
| <dimen name="job_card_corner_radius">16dp</dimen> | |||
| <dimen name="job_card_start_end_margin">8dp</dimen> | |||
| <dimen name="zoom_on_cluster_click_padding">50dp</dimen> | |||
|
|
|||
| <!-- Standard Spacing --> | |||
| <dimen name="spacing_small">4dp</dimen> | |||
There was a problem hiding this comment.
CI is failing because these are unused. Maybe add the first reference to them to this PR and use elsewhere as needed in follow-ups?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2913
@gino-m PTAL?
Can we generalize the values or should we go feature by feature?