Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix Play services install and sign in flow #2924

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
+82 −76
Draft

[WIP] Fix Play services install and sign in flow #2924

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef6981f
Add logging, syntactic sugar
gino-m Dec 13, 2024
2ed559c
Add debug logging
gino-m Dec 13, 2024
def1b29
Recast "main UI nav request" as "main UI state"
gino-m Dec 13, 2024
0625122
Ensure state is restored on resume
gino-m Dec 13, 2024
576235f
ktfmt
gino-m Dec 13, 2024
6f81a45
Catch cancellation exceptions
gino-m Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Catch cancellation exceptions
  • Loading branch information
@gino-m
gino-m committed Dec 13, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
commit 6f81a451ab71a8fedc268c9c5633c1dc7135a958
3 changes: 3 additions & 0 deletions ground/src/main/java/com/google/android/ground/ui/startup/StartupFragment.kt
View file
Original file line number Diff line number Diff line change
@@ -26,6 +26,7 @@ import com.google.android.ground.ui.common.AbstractFragment
import com.google.android.ground.ui.common.EphemeralPopups
import dagger.hilt.android.AndroidEntryPoint
import javax.inject.Inject
import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.launch
import timber.log.Timber

@@ -53,6 +54,8 @@ class StartupFragment : AbstractFragment() {
viewLifecycleOwner.lifecycleScope.launch {
try {
viewModel.initializeLogin()
} catch (e: CancellationException) {
Timber.d(e, "Startup job cancelled")
} catch (t: Throwable) {
onInitFailed(t)
}