-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate the TODO format check and fix older format #2904
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2904 +/- ##
=========================================
Coverage 62.54% 62.54%
Complexity 1203 1203
=========================================
Files 267 267
Lines 6357 6357
Branches 879 879
=========================================
Hits 3976 3976
Misses 1831 1831
Partials 550 550
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anandwana001 for adding the detekt check. A single ticket isn't really helpful for tracking those TODO, though - ideally we'd have a ticket for each issue or class of issues.
Also note that I've started adding the full URL of the ticket to the TODO()
tag so that they're clickable in Android Studio. That will usually cause the TODO to wrap onto the next line, in which case you can intent two spaces to ensure AS interprets the second line as part of the same TODO.
@gino-m
Hence this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added links to appropriate issues, creating them where appropriate.
Idea: Can we use https://github.com/marketplace/actions/todo-to-issue to auto-generate issues for each TODO as they're added in the future? In that case we'd have a different format for TODO URLs:
// TODO: Todo description
// Issue URL: ...github url.
@shobhitagarwal1612 @scolsen Wdyt? If you agree I can enable the plugin and try it out.
Wdyt? If you like the idea I can enable the plugin for you to try out.
ground/src/main/java/com/google/android/ground/model/submission/SubmissionData.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/model/submission/MultipleChoiceTaskData.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/model/submission/CaptureLocationTaskData.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/MainViewModel.kt
Outdated
Show resolved
Hide resolved
...t/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskFragmentTest.kt
Outdated
Show resolved
Hide resolved
.../java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskViewModelTest.kt
Outdated
Show resolved
Hide resolved
...src/test/java/com/google/android/ground/ui/datacollection/tasks/time/TimeTaskFragmentTest.kt
Outdated
Show resolved
Hide resolved
sharedTest/src/main/kotlin/com/sharedtest/system/auth/FakeAuthenticationManager.kt
Outdated
Show resolved
Hide resolved
We spoke.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once nit, otherwise LGTM
…nto anandwana001/2178/todo-format
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/offlineareas/viewer/OfflineAreaViewerFragment.kt
Fixes #2178
Fixes #2841
@gino-m @shobhitagarwal1612 PTAL?