Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Navigator from HomeScreenFragment #2896

Merged
merged 14 commits into from
Dec 5, 2024

Merge remote-tracking branch 'origin/anandwana001/2895/remove-navigat…

71d4810
Select commit
Loading
Failed to load commit list.
Merged

Removed Navigator from HomeScreenFragment #2896

Merge remote-tracking branch 'origin/anandwana001/2895/remove-navigat…
71d4810
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

61.57% (-0.06%) compared to 8349e55

View this Pull Request on Codecov

61.57% (-0.06%) compared to 8349e55

Details

Codecov Report

Attention: Patch coverage is 22.50000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 61.57%. Comparing base (8349e55) to head (71d4810).

Files with missing lines Patch % Lines
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 16 Missing ⚠️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 38.09% 12 Missing and 1 partial ⚠️
...ground/ui/datacollection/DataCollectionFragment.kt 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2896      +/-   ##
============================================
- Coverage     61.62%   61.57%   -0.06%     
+ Complexity     1178     1176       -2     
============================================
  Files           269      269              
  Lines          6372     6361      -11     
  Branches        883      878       -5     
============================================
- Hits           3927     3917      -10     
+ Misses         1900     1899       -1     
  Partials        545      545
Files with missing lines Coverage Δ
...ui/datacollection/tasks/photo/PhotoTaskFragment.kt 32.92% <ø> (+0.39%) ⬆️
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 68.57% <100.00%> (-10.68%) ⬇️
...ground/ui/datacollection/DataCollectionFragment.kt 56.56% <0.00%> (+0.56%) ⬆️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 58.87% <38.09%> (+3.87%) ⬆️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 16.86% <0.00%> (-0.20%) ⬇️
View more details on Codecov