Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Navigator from TermsOfServiceFragment, SurveySelectorFragment and OfflineAreasFragment #2889

Merged
merged 9 commits into from
Dec 5, 2024

removed viewlifecycle scope

72cb011
Select commit
Loading
Failed to load commit list.
Merged

Removed Navigator from TermsOfServiceFragment, SurveySelectorFragment and OfflineAreasFragment #2889

removed viewlifecycle scope
72cb011
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 4, 2024 in 0s

61.62% (-0.06%) compared to 9ab91bc

View this Pull Request on Codecov

61.62% (-0.06%) compared to 9ab91bc

Details

Codecov Report

Attention: Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.

Project coverage is 61.62%. Comparing base (9ab91bc) to head (72cb011).

Files with missing lines Patch % Lines
...flineareas/selector/OfflineAreaSelectorFragment.kt 11.11% 7 Missing and 1 partial ⚠️
...oid/ground/ui/offlineareas/OfflineAreasFragment.kt 71.42% 1 Missing and 1 partial ⚠️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 50.00% 2 Missing ⚠️
...android/ground/ui/offlineareas/selector/UiState.kt 0.00% 2 Missing ⚠️
...i/offlineareas/viewer/OfflineAreaViewerFragment.kt 66.66% 0 Missing and 1 partial ⚠️
...ground/ui/surveyselector/SurveySelectorFragment.kt 50.00% 0 Missing and 1 partial ⚠️
...le/android/ground/ui/tos/TermsOfServiceFragment.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2889      +/-   ##
============================================
- Coverage     61.68%   61.62%   -0.06%     
- Complexity     1173     1178       +5     
============================================
  Files           268      269       +1     
  Lines          6344     6372      +28     
  Branches        876      883       +7     
============================================
+ Hits           3913     3927      +14     
- Misses         1890     1900      +10     
- Partials        541      545       +4
Files with missing lines Coverage Δ
...id/ground/ui/offlineareas/OfflineAreasViewModel.kt 100.00% <100.00%> (ø)
.../offlineareas/viewer/OfflineAreaViewerViewModel.kt 100.00% <100.00%> (ø)
...round/ui/surveyselector/SurveySelectorViewModel.kt 93.61% <100.00%> (-0.39%) ⬇️
...google/android/ground/ui/surveyselector/UiState.kt 100.00% <100.00%> (ø)
...i/offlineareas/viewer/OfflineAreaViewerFragment.kt 47.82% <66.66%> (+2.82%) ⬆️
...ground/ui/surveyselector/SurveySelectorFragment.kt 59.32% <50.00%> (-2.09%) ⬇️
...le/android/ground/ui/tos/TermsOfServiceFragment.kt 88.23% <85.71%> (-1.77%) ⬇️
...oid/ground/ui/offlineareas/OfflineAreasFragment.kt 70.37% <71.42%> (+6.73%) ⬆️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 25.97% <50.00%> (+0.97%) ⬆️
...android/ground/ui/offlineareas/selector/UiState.kt 0.00% <0.00%> (ø)
... and 1 more
View more details on Codecov